> On June 17, 2015, 8:23 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 332 > > <https://reviews.apache.org/r/35561/diff/1/?file=986458#file986458line332> > > > > Aren't we leaking this one in the parent process? > > Benjamin Hindman wrote: > We'll be exec'ing, so they'll get "freed" then. Same applies for the > 'char** argv' above. Want an extra comment?
Then why do we `delete[] _argv;` below? :) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35561/#review88265 ----------------------------------------------------------- On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35561/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 2:28 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2832 > https://issues.apache.org/jira/browse/MESOS-2832 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > 425b119e5eb122fa21c3e54fe070c7d553958f2c > 3rdparty/libprocess/src/subprocess.cpp > f41f5e2a34788e31749eb996c8ab38ea45989068 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > b5cfc8d3daff489b332b6bfef2872cef9abecefe > > Diff: https://reviews.apache.org/r/35561/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
