-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35405/#review88437
-----------------------------------------------------------



src/sched/sched.cpp (line 1659)
<https://reviews.apache.org/r/35405/#comment140952>

    s/a bunch //



src/sched/sched.cpp (line 1660)
<https://reviews.apache.org/r/35405/#comment140953>

    Should we maybe mention the GC issue with JVM (to get a bit more concrete).



src/sched/sched.cpp (lines 1662 - 1672)
<https://reviews.apache.org/r/35405/#comment140954>

    Can you break this comment up a bit. A lot to swallow in one sentence :)



src/sched/sched.cpp (lines 1670 - 1672)
<https://reviews.apache.org/r/35405/#comment140955>

    Should we turn that into a JIRA and reference from here?



src/tests/mesos.hpp (line 712)
<https://reviews.apache.org/r/35405/#comment140956>

    s/is greater/exceeds/? If it is a notion of time


- Niklas Nielsen


On June 18, 2015, 5:39 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35405/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 5:39 a.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a proof of concept to help folks out in 
> https://reviews.apache.org/r/33208.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp bc76c71ae9d44bdddd291049223366e38cb0fd0c 
>   src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 
> 
> Diff: https://reviews.apache.org/r/35405/diff/
> 
> 
> Testing
> -------
> 
> NOT YET
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to