> On June 18, 2015, 5:27 p.m., Jie Yu wrote:
> > src/slave/slave.cpp, line 1409
> > <https://reviews.apache.org/r/35433/diff/5/?file=986979#file986979line1409>
> >
> >     Have we decided to not capture temp variable by const ref? Maybe you 
> > want to do a sweep to fix that in this file?

I fixed it in this review to begin with, but decided that it would be easier 
for folks to review if I split it out: https://reviews.apache.org/r/35638


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88406
-----------------------------------------------------------


On June 19, 2015, 12:42 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35433/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> No bug was observed (yet), but realized I forgot about this in the dynamic 
> reservations patches.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b 
> 
> Diff: https://reviews.apache.org/r/35433/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to