-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/#review88478
-----------------------------------------------------------

Ship it!



src/tests/hierarchical_allocator_tests.cpp (line 984)
<https://reviews.apache.org/r/35631/#comment141036>

    Maybe a 1000 and 50,000 as well?



src/tests/hierarchical_allocator_tests.cpp (lines 991 - 993)
<https://reviews.apache.org/r/35631/#comment141034>

    Doesn't this need to be an atomic?


- Ben Mahler


On June 19, 2015, 1:11 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35631/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 1:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2892
>     https://issues.apache.org/jira/browse/MESOS-2892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a performance benchmark for hierarchical allocator addSlave.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba 
>   src/tests/registrar_tests.cpp ebcce73b627b3cee044bf239c4d3ba9753a8fa73 
> 
> Diff: https://reviews.apache.org/r/35631/diff/
> 
> 
> Testing
> -------
> 
> bin/mesos-test.sh --benchmark
> 
> 0.23.0 current master
> 
> 
> 0.23.0 before MESOS-2373
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to