> On June 18, 2015, 7:44 p.m., Joris Van Remoortere wrote: > > Hey Mark, > > Can you make the dependency chain purely linear so the reviewbot can apply > > the patches correctly and build / run the tests? > > `35287->35286->35285` > > Mark Wang wrote: > I submit a new review without any change then I try to discard the draft, > I got "HTTP 500 INTERNAL SERVER ERROR" > can't get around with this..
issue solved. I had to use rbt tool to publish. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/#review88429 ----------------------------------------------------------- On June 20, 2015, 4:49 p.m., Mark Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35285/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 4:49 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-2800 > https://issues.apache.org/jira/browse/MESOS-2800 > > > Repository: mesos > > > Description > ------- > > Rename Option<T>::get(const T& _t) to getOrElse() and refactor original > functions (mesos) > > > Diffs > ----- > > src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 > src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294 > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/slave/containerizer/containerizer.cpp > e995ce602261c18373ac09c823638c4a252cca86 > src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 > > Diff: https://reviews.apache.org/r/35285/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Mark Wang > >
