----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35715/#review88704 -----------------------------------------------------------
Patch looks great! Reviews applied: [35715] All tests passed. - Mesos ReviewBot On June 21, 2015, 5:10 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35715/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 5:10 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > In `mesos.proto`, it specifies the expected state of revocable resource: > > ``` > // ... Note that if this is set, 'disk' or 'reservation' cannot be set. > optional RevocableInfo revocable = 9; > ``` > > This expectation should be validated in `Resources::validate(const Resource& > resoure)` > > > Diffs > ----- > > src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 > src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332 > > Diff: https://reviews.apache.org/r/35715/diff/ > > > Testing > ------- > > Added `RevocableResourceTest.Validation` + `make check` > > > Thanks, > > Michael Park > >
