-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35438/#review88789
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35438]

All tests passed.

- Mesos ReviewBot


On June 22, 2015, 2:57 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35438/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 2:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: 2815, 2831, 2857, and 2858
>     https://issues.apache.org/jira/browse/2815
>     https://issues.apache.org/jira/browse/2831
>     https://issues.apache.org/jira/browse/2857
>     https://issues.apache.org/jira/browse/2858
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up to RR https://reviews.apache.org/r/35247/, which was not good 
> enough, fixed only one of two problems.
> 
> Using DeclineOffers() instead of Return() should make the master resend 
> offers so we can launch tasks. See line 205 below.
> 
> Following Jie's suggestion, no more CHECK_READY inside launchTask(s)(), but 
> we return a Try instead and follow call sites with EXPECT_SOME(task(s)).
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392 
> 
> Diff: https://reviews.apache.org/r/35438/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Reply via email to