> On June 22, 2015, 9:37 p.m., Chi Zhang wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1886-1889
> > <https://reviews.apache.org/r/35744/diff/1/?file=989925#file989925line1886>
> >
> >     If we have 0 known orphans, 3 unknown orphans, we'd try to delete ICMP 
> > and ARP 3 times in the new loop?
> 
> Jie Yu wrote:
>     Yeah, that's the reason I put that TODO. The second `_cleanup` will fail 
> and the recovery will fail. The slave will restart and cleanup the 3rd 
> unknown orphan. So it's OK for now.

I added a NOTE about that.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35744/#review88849
-----------------------------------------------------------


On June 22, 2015, 9:58 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35744/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone.
> 
> 
> Bugs: MESOS-2914
>     https://issues.apache.org/jira/browse/MESOS-2914
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up the unknown orphans after all known orphans are recovered.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 137cdc9b064b02e829af857cff7b9023ee7b7b16 
> 
> Diff: https://reviews.apache.org/r/35744/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Will follow up a test later.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to