-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/#review88870
-----------------------------------------------------------



include/mesos/slave/isolator.hpp (lines 105 - 116)
<https://reviews.apache.org/r/35585/#comment141455>

    This is not exactly an enum since we need to perform bit-wise OR on the 
enum which seems to be quite weired for an enum.
    
    I would suggest we still stick to an 'int' as you originally did.



include/mesos/slave/isolator.hpp (line 130)
<https://reviews.apache.org/r/35585/#comment141458>

    Given the TODO here, does it make sense to return an Option<int>. We return 
None() if namespaces does not apply?
    ```
    Future<Option<int>> namespaces();
    ```


- Jie Yu


On June 22, 2015, 5:56 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35585/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 5:56 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2884
>     https://issues.apache.org/jira/browse/MESOS-2884
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would enable the MesosContainerizer to pass on a list of namespaces
> to LinuxLauncher instead of having LinuxLauncher guess it from the
> isolation flags.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp 18edc030367e42240090f2f3dbc92aec7a4c6234 
>   src/slave/containerizer/isolator.cpp 
> d51ecc9347cafef90c92a6965e37f417b4929e79 
>   src/slave/containerizer/isolators/filesystem/shared.hpp 
> 08c6ffea0e2fada8e0b04f4ab15d8569c5416a8e 
>   src/slave/containerizer/isolators/namespaces/pid.hpp 
> 6b24e2990311d0b09b3f6f2bb4ab29ee83fddddc 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 7777ee869ce71a68f51d58159c701d3c5d1e502b 
> 
> Diff: https://reviews.apache.org/r/35585/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Reply via email to