----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/#review88875 -----------------------------------------------------------
Ship it! let us definitely improve the info pointer management, there is 7 'delete info' in this file right now... :( - Chi Zhang On June 22, 2015, 11:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35749/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 11:29 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. > > > Bugs: MESOS-2914 > https://issues.apache.org/jira/browse/MESOS-2914 > > > Repository: mesos > > > Description > ------- > > Fixed a memory bug in port mapping recovery logic. Info will be deleted in > `_cleanup` (a little weired, we can fix that later). > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > 4de737a158da2ab329de7c57b9b52de305606bf0 > > Diff: https://reviews.apache.org/r/35749/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
