----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88919 -----------------------------------------------------------
Ship it! include/mesos/slave/isolator.hpp (lines 78 - 104) <https://reviews.apache.org/r/35585/#comment141532> Any reason you want to keep these defined here in the public header? IIUC, these are workaround for those who are using an old glibc. Can you instead include src/linux/ns.hpp in the corresponding isolator source file? include/mesos/slave/isolator.hpp (lines 113 - 114) <https://reviews.apache.org/r/35585/#comment141533> Can you comment on what does that mean if None() is returned? src/slave/containerizer/isolators/filesystem/shared.hpp (lines 42 - 45) <https://reviews.apache.org/r/35585/#comment141534> Can you move this to the cpp file and include src/linux/ns.hpp? src/slave/containerizer/isolators/namespaces/pid.hpp (lines 59 - 62) <https://reviews.apache.org/r/35585/#comment141535> Ditto. src/slave/containerizer/isolators/network/port_mapping.hpp (lines 155 - 158) <https://reviews.apache.org/r/35585/#comment141536> Ditto on moving to cpp file. - Jie Yu On June 23, 2015, 2:48 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35585/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 2:48 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-2884 > https://issues.apache.org/jira/browse/MESOS-2884 > > > Repository: mesos > > > Description > ------- > > This would enable the MesosContainerizer to pass on a list of namespaces > to LinuxLauncher instead of having LinuxLauncher guess it from the > isolation flags. > > > Diffs > ----- > > include/mesos/slave/isolator.hpp 18edc030367e42240090f2f3dbc92aec7a4c6234 > src/slave/containerizer/isolator.cpp > d51ecc9347cafef90c92a6965e37f417b4929e79 > src/slave/containerizer/isolators/filesystem/shared.hpp > 08c6ffea0e2fada8e0b04f4ab15d8569c5416a8e > src/slave/containerizer/isolators/namespaces/pid.hpp > 6b24e2990311d0b09b3f6f2bb4ab29ee83fddddc > src/slave/containerizer/isolators/network/port_mapping.hpp > 7777ee869ce71a68f51d58159c701d3c5d1e502b > > Diff: https://reviews.apache.org/r/35585/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
