-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88934
-----------------------------------------------------------


lgtm - thanks for the fix, much appreciated.

- Till Toenshoff


On June 23, 2015, 7:17 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35771/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 7:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-757
>     https://issues.apache.org/jira/browse/MESOS-757
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If you're not logged into ReviewBoard and run `post-reviews.py` the script 
> hangs when trying to create a diff.
> 
> After pressing enter, if you're not logged in, you get the following error 
> message:
> 
> ```
> ...
> 
> Press enter to continue or 'Ctrl-C' to skip.
> 
> Please log in to the Review Board server at reviews.apache.org.
> 
> You can either:
>   (1) Run 'rbt login', or
>   (2) Set the default USERNAME/PASSWORD in '.reviewboardrc'
> ```
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c 
> 
> Diff: https://reviews.apache.org/r/35771/diff/
> 
> 
> Testing
> -------
> 
> (1) `rbt logout` to log out of ReviewBoard
> (2) Removed `USERNAME`/`PASSWORD` from `.reviewboardrc` so that `rbt` doesn't 
> use it to log in automatically.
> (3) Observed the error message shown in __Description__
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to