----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/#review89032 -----------------------------------------------------------
src/slave/containerizer/linux_launcher.hpp (line 33) <https://reviews.apache.org/r/35586/#comment141637> Please use const Option<int>& as least:) - Jie Yu On June 23, 2015, 7:05 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35586/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 7:05 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-2884 > https://issues.apache.org/jira/browse/MESOS-2884 > > > Repository: mesos > > > Description > ------- > > MesosContainerizer looks up the list of required namespaces by calling > Isolator::namespaces() for all enabled isolators and passes on this > value to LinuxLauncher. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.hpp > ec08e24b9ba525893d218636ebddea480e641bbf > src/slave/containerizer/linux_launcher.cpp > 8eae258d81229e19f8c587f5e023b1df7deed025 > src/slave/containerizer/mesos/containerizer.cpp > 8c102fb7d1f79ee768cb06de3a976ea12f958712 > src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 > src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d > > Diff: https://reviews.apache.org/r/35586/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
