> On June 22, 2015, 10:02 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 418 > > <https://reviews.apache.org/r/35743/diff/1/?file=989917#file989917line418> > > > > boost::size(...) would suffice here too albeit minus the small trivial > > run-time cost.
Not sure if adding a boost dependency just for size operator would get us anything here. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/#review88852 ----------------------------------------------------------- On June 22, 2015, 9:27 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35743/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 9:27 p.m.) > > > Review request for mesos, Benjamin Hindman and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Changes: > - replacing argument arrays with static initializers in tests. > - making the argument 'argv' const in load method to reflect the semantics. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 7584cb871d02ad01021f0c3439ea205736d4f6b4 > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > c2c6a6ac97044f2317418295f48d75e94de4112b > > Diff: https://reviews.apache.org/r/35743/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
