> On June 23, 2015, 11:31 p.m., Isabel Jimenez wrote: > > src/sched/sched.cpp, line 438 > > <https://reviews.apache.org/r/35752/diff/1/?file=990748#file990748line438> > > > > Aren't we using braces on switch cases syntax? like: > > ``` > > switch (type) { > > case ENUM: { > > break > > } > > } > > ```
Only if needed Isabel ... So when case specific variable declarations are needed, scoping is needed. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35752/#review89085 ----------------------------------------------------------- On June 23, 2015, 7:26 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35752/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 7:26 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2910 > https://issues.apache.org/jira/browse/MESOS-2910 > > > Repository: mesos > > > Description > ------- > > Adds an initial handler, with an implementation for ERROR events. > > > Diffs > ----- > > src/Makefile.am dfebd2b14c9cb45c437509809fdf5ac3b0c8838c > src/sched/sched.cpp bc76c71ae9d44bdddd291049223366e38cb0fd0c > src/tests/scheduler_event_call_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/35752/diff/ > > > Testing > ------- > > For now, testing needs to be done via manual injection of events. I've added > a new test file for this, which will include the driver and library tests for > event / call handling. We should be able to remove these tests as all of the > existing tests will later test the event/call path. > > > Thanks, > > Ben Mahler > >
