-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89246
-----------------------------------------------------------

Ship it!


Great catch! Thanks for these Paul, just minor comments regarding comments :P


3rdparty/libprocess/include/process/future.hpp (lines 816 - 818)
<https://reviews.apache.org/r/35841/#comment141830>

    Can we add the comment here as well?
    
    ```
    // ATOMIC_FLAG_INIT is not available on member locks, so we
    // unconditionally clear the lock instead.
    ```



3rdparty/libprocess/include/process/mutex.hpp (lines 65 - 66)
<https://reviews.apache.org/r/35841/#comment141829>

    Can we consistently use this comment? or is this case different somehow?
    
    ```
    // ATOMIC_FLAG_INIT is not available on member locks, so we
    // unconditionally clear the lock instead.
    ```


- Michael Park


On June 24, 2015, 8:15 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35841/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 8:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Chi Zhang, Ian 
> Downes, Jie Yu, Joris Van Remoortere, Vinod Kone, and Cong Wang.
> 
> 
> Bugs: MESOS-2925
>     https://issues.apache.org/jira/browse/MESOS-2925
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix usage of ATOMIC_FLAG_INIT
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 
> b20eb0683c6c4491eabaada46ae8d35d8a89ebaf 
>   3rdparty/libprocess/include/process/http.hpp 
> e47cc7afbc8110759edf25a2dc05d09eda25c417 
>   3rdparty/libprocess/include/process/metrics/metric.hpp 
> 44a7d5a272f5e5e86634c12b1003049ba0e4f932 
>   3rdparty/libprocess/include/process/metrics/timer.hpp 
> fd7b2db15f596b192f64658fae846b3899e8d1d0 
>   3rdparty/libprocess/include/process/mutex.hpp 
> 8fff089e2654bf1a5ac3cfec91def7688e0009ca 
>   3rdparty/libprocess/include/process/queue.hpp 
> 1496b3850648957ff34bf2bbe240d1ab0888c6f8 
> 
> Diff: https://reviews.apache.org/r/35841/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to