> On June 25, 2015, 2:02 p.m., Michael Lunøe wrote:
> > So I had a look into it. So the project built on an old Bootstrap CSS file.
> > 
> > The solution to our problem will be solved by updating the Bootstrap CSS 
> > file with a new build, as container-fluid was introduced later in 
> > Bootstrap. I attached an updated build, which you can replace in the 
> > project.
> > 
> > Please replace the file src/webui/master/static/bootstrap-3.0.3.min.css 
> > with the attached file, bootstrap-3.3.4.min.css. Also change the reference 
> > in the index.html file:
> > <link href="/static/css/bootstrap-3.0.3.min.css" rel="stylesheet">
> > Gets replaced by:
> > <link href="/static/css/bootstrap-3.3.4.min.css" rel="stylesheet">
> > 
> > I looked through the change log and the only thing that we are using, that 
> > got deprecated is the hide classes. Search and replace the string " hide" 
> > with " hidden" (including the leading space character) in html the files. 
> > There are 6 occurrences, all together.
> > 
> > Also in home.html:
> > <div class="col-md-3">
> > Gets replaced by: 
> > <div class="col-sm-4 col-md-3 col-lg-2">
> > 
> > And the second column in home.html:
> > <div class="col-md-9"> 
> > Gets replaced by: 
> > <div class="col-sm-8 col-md-9 col-lg-10">
> > 
> > That should be it.

the problem being that this is a hardcoded solution that does not worl for all 
screen sizes and does not work with, but against bootstrap styles


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32750/#review89345
-----------------------------------------------------------


On April 2, 2015, 10:26 p.m., Alson Kemp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32750/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 10:26 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2585
>     https://issues.apache.org/jira/browse/MESOS-2585
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-2585: Use full width for mesos div.container
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
> 
> Diff: https://reviews.apache.org/r/32750/diff/
> 
> 
> Testing
> -------
> 
> Visual verification.
> 
> 
> Thanks,
> 
> Alson Kemp
> 
>

Reply via email to