> On June 25, 2015, 2:54 p.m., Benjamin Hindman wrote:
> > docs/mesos-doxygen-style-guide.md, line 20
> > <https://reviews.apache.org/r/35843/diff/1/?file=991532#file991532line20>
> >
> >     Seems like most of the examples in this file should still be ~~~{.cpp}? 
> > I'll fix before commit.

Actually not. If you wrap it with ~~~{.cpp} doxygen will strip most of the 
comments out (we have STRIP_CODE_COMMENTS = YES in Doxyfile, probably for a 
good reason). That is why in places where I wanted to preserve comments I 
intentionally used indentation.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/#review89311
-----------------------------------------------------------


On June 24, 2015, 7:57 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35843/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 7:57 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Making markup doxygen-friendly
> 
> 
> Diffs
> -----
> 
>   docs/allocation-module.md 5db4aa22ee66d5c320378cbdcbc082782d31ed73 
>   docs/app-framework-development-guide.md 
> d651ec8b20977ddbe5578558f164ba7805b2ad25 
>   docs/clang-format.md 909a253b699fca37ae4ea0f8c9d680c9a5f012ed 
>   docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
>   docs/mesos-doxygen-style-guide.md 93a5e70a4a78bc3a6e83206b06f45dd28e9daa99 
>   docs/mesos-markdown-style-guide.md 7ea0b1d7e00ac05ecf438fc22f2f62483f2db37b 
>   docs/mesos-testing-patterns.md 6383786419fec23ad49289b594979f0657e1fe83 
>   docs/modules.md d323f2adfa3c5e431f7dbfe79402fe8de081cf80 
>   docs/network-monitoring.md 680f771806772c84973613eaee48ddf3b57fd858 
>   docs/reconciliation.md ae4a99c334093a9d085df06d7f49af555516f045 
>   docs/release-guide.md 38ecbec75db59b457c3b55003665a51ba10fc254 
>   docs/upgrades.md 355307a5f301d73a0c7d0541f509a45c1fc9a72b 
> 
> Diff: https://reviews.apache.org/r/35843/diff/
> 
> 
> Testing
> -------
> 
> This is a documentation only change:
>   - Replacing triple backtics with tildes  
>   - Adding .cpp for code blocks  
>   - Using indentation where tildes produces line numbers
> 
> Rendered all the pages from scratch using doxygen as well as rake/middleman. 
> Reviewd all affected pages.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Reply via email to