----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35856/#review89436 -----------------------------------------------------------
Ship it! src/tests/scheduler_tests.cpp (line 736) <https://reviews.apache.org/r/35856/#comment142061> Same comment as the other review :) Great test, worth maybe factoring some of the common functionality in a helper class? - Marco Massenzio On June 25, 2015, 12:29 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35856/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 12:29 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and > Marco Massenzio. > > > Bugs: MESOS-2551 > https://issues.apache.org/jira/browse/MESOS-2551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df > src/scheduler/scheduler.cpp 1efc6fb351e49deaa8f626823592bc9155f5137b > src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f > > Diff: https://reviews.apache.org/r/35856/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >