-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89440
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35861]

All tests passed.

- Mesos ReviewBot


On June 25, 2015, 9:58 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35861/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2928
>     https://issues.apache.org/jira/browse/MESOS-2928
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Correct #include list errors for stout discovered by running a patched 
> cpplint which has a fixed list of mesos vs. external library include 
> directories.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
> 4a26736cf8b70fa458a74813c365c8e693306271 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
> 9714d9abe4ad523d819c7dc713f7d791c47e4ec4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
> ac823f13177863fdd7080bc043b56f2b898dc26f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
> 067be3a15416484b15e90420355c39fbf2cb518a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> 7527f729fb0983a7647eb5a9b526a0ca90ac762d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
> 9bd19fdb457de26eb12b16d0131d86923a8b199a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 
> 7c2751336c665e01fecbcd98bf5eac5a81195fe2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> c967de9193cb6496a92b3364986be34cb3eeeca3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> 69cd81e0149250562469446564cd1c6a459b15b0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> c283b764c3c1f51cb8941adaeb052749eb426c1b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 
> d72b4c19573be6f4eebfadef3c36cff350312bbb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> 0850ae9f5fffe9acc5083f5992225771c46e92cb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
> c8d30d8c193eb14f7accfde4fe02ce0710cd1817 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
> 59cde89b5e035807a510b331b85a8cd48da36ae3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 
> cfe6d742560f50079fb1ed7346526d432615613c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 
> a1e6e4d131e15c31135d72399e5e6825e7dd0141 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 
> aa0d1270712494fde9a49c54f8f58b092d573682 
>   3rdparty/libprocess/3rdparty/stout/include/stout/preprocessor.hpp 
> e5f2037b634272304a216619546c873b34a661a2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 2c020d98b94995bce862ac3b9c173dd64ed1198d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 
> 702ed0b9f8daa387252059587c45aa43437c040e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/tests/utils.hpp 
> 494bacac4378f4eda144ba7effe39a2ad61853df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp 
> 892246bca43c196d98cc9d614ede395e416e5964 
>   3rdparty/libprocess/3rdparty/stout/include/stout/utils.hpp 
> 09a1dcd3b3a082544d221fbfeab9a3d3d9f85e2f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> c6bf1a8ec0e2b10bcb7a99dc3004c872f98ba4a3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 
> 090fcf09dd96538a8748cf4443d150911e2c0d27 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 
> 3065278ae94bc4c3d754133d88c4da9d6e195fcb 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 
> d86b0ea2f29740ddc6fd798502526ac973a8a5de 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> c2c6a6ac97044f2317418295f48d75e94de4112b 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 
> 13296d8c13dfb68b016641964753ac5822de6897 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 
> 19a0f5894bfcc6dfdd563e54a7b0bf2b6404ccbc 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 
> 3c4b732432c0c155451d34ecd5f985318d118fe5 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> 5ade9bda6d66f65cab8c93337ddc829e0ca12772 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 
> 685a9a197c3a001a6a424a017ea20cc7ab76f7e7 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 
> 79e720040e55de5aa68511d65cacf3952a57081a 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 
> 38d25bbd688696f8705186c6b1864c38ddf4b71a 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
> 0e5d45148042fce8953f955faeef271164a13525 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 
> 3d1b966801503d359455272ef4fcd8e88f1d5368 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 
> d07b95c969aa842bd81c8fb589ae17c19b51c14b 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 7327ad2f69fa7a81b021f3c455834e6e470d8eef 
>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 
> 3007c2a52123b3bcb6b5a2602560cd727eaf25af 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 
> 60a94ab0a4d09e176c5f3b20407bf070307b92ea 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 06511858dde89fc74ef5826951dfa474c630bc97 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 
> cdedacde1247e766e240ea1c2d86573c6ecccafd 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 
> 1e5f4494204c8901552afcb7e61fd503651949dc 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 
> b90057972d22123d655697425581cc2767ec825d 
>   3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp 
> c40bba4f1e7eef7cb04f79b567e32684648b2004 
>   3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp 
> d5e0f6efd6f6c92abbafa70e041064db2ae58cac 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 
> b37d7f4e99da8fd3211397ebbb75f070229f9f81 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 
> bcf7252730fd5cefbd4e851c333c40948a8ad751 
> 
> Diff: https://reviews.apache.org/r/35861/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to