> On May 13, 2015, 10:25 p.m., Marco Massenzio wrote: > > docs/reservation.md, lines 97-100 > > <https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line97> > > > > Let us please add at least a suggestion of the possible error codes > > (and a couple Response bodies) here too - at least people can comment. > > > > Here's my suggestion: > > ``` > > 400 - something went wrong, err_msg in JSON > > 401 - the role/framework is not authorized to reserve stuff > > 403 - the configuration and/or this slave do not allow reserved > > resources > > 409 - you can't do this; for example: I offered you 4 CPUs and you want > > to reserve 8 > > ``` > > and our all-time favorite: > > ``` > > 404 - the resources you want to reserve cannot be found ("name": > > "cash", "value": "$2MM") > > ``` > > Only half-joking here: I can't think of any situation where a request > > like this could give a 404, but maybe there are some? > > > > My recommendation would be to have the codes here (and for `unreserve` > > too) so that people can comment.
The possible HTTP responses currently are: `200 OK`, `400 BadRequest`, `401 Unauthorized` and `409 Conflict`. We could potentially introduce `403 Forbidden` and `404 Not Found` if they fit. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83674 ----------------------------------------------------------- On June 26, 2015, 8:35 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32982/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 8:35 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2205 > https://issues.apache.org/jira/browse/MESOS-2205 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/reservation.md PRE-CREATION > > Diff: https://reviews.apache.org/r/32982/diff/ > > > Testing > ------- > > Documentation. > > > Thanks, > > Michael Park > >
