----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35935/#review89578 -----------------------------------------------------------
Patch looks great! Reviews applied: [35909, 35914, 35943, 35910, 35911, 35912, 35935] All tests passed. - Mesos ReviewBot On June 26, 2015, 9:33 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35935/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 9:33 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-2941 > https://issues.apache.org/jira/browse/MESOS-2941 > > > Repository: mesos > > > Description > ------- > > We currently don't have any nice testing abstractions for scaling up a master > in-memory, so this simulates the reconciliation logic instead. Not ideal, but > was very valuable for improving the performance. > > > Diffs > ----- > > src/tests/reconciliation_tests.cpp 6042d8c02d86f486e0c4d82d5a70666d7ac9019b > > Diff: https://reviews.apache.org/r/35935/diff/ > > > Testing > ------- > > make check + ran the benchmark (per MESOS-2940) > > > Thanks, > > Ben Mahler > >
