----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89723 -----------------------------------------------------------
Ship it! Looks great! Just a few formatting/wrapping nits, but I can fix those before committing this. src/slave/containerizer/mesos/containerizer.cpp (lines 1335 - 1343) <https://reviews.apache.org/r/35721/#comment142437> FYI, we generally wrap at a consistent 70 characters in comments, rather than waiting for punctuation. I would reformat this before committing. src/slave/containerizer/mesos/containerizer.cpp (lines 1346 - 1348) <https://reviews.apache.org/r/35721/#comment142440> "'" + ": " should just be "': " Also, these three lines could fit on two. We wrap code at 80 chars. src/slave/containerizer/mesos/containerizer.cpp (line 1351) <https://reviews.apache.org/r/35721/#comment142445> I guess we don't need to care about the value of `flags.switch_user` here, since the sandbox will always be set to the correct permissions, regardless of whether `switch_user` is enabled. Nice solution. src/slave/containerizer/mesos/containerizer.cpp (lines 1353 - 1356) <https://reviews.apache.org/r/35721/#comment142438> These four lines could easily fit on two. We wrap code at 80 chars. - Adam B On June 28, 2015, 7:36 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35721/ > ----------------------------------------------------------- > > (Updated June 28, 2015, 7:36 p.m.) > > > Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. > > > Bugs: MESOS-2603 > https://issues.apache.org/jira/browse/MESOS-2603 > > > Repository: mesos > > > Description > ------- > > Set the ownership of persistent volume to match the sandbox directory. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 313e9b74d3a0157609226041246575d2c4a503f8 > > Diff: https://reviews.apache.org/r/35721/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
