-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
-----------------------------------------------------------

(Updated July 1, 2015, 3:24 p.m.)


Review request for mesos and Till Toenshoff.


Changes
-------

ACLs related protobuf messages are extracted from `mesos.proto` and given their 
own `authorization.proto`


Repository: mesos


Description
-------

Breaks the declaration of the `Authorizer` interface and its default 
implementation `LocalAuthorizer` in different files.

Makes the `Authorizer` interface declaration public.

Following the patter in the `Authenticator` it generates a default constructor 
which is required when writing a `TypeTest` in a follow up patch, and an 
`initialize` method.

Other changes are just updates to allow for compilation.


Diffs (updated)
-----

  include/mesos/authorizer/authorization.hpp PRE-CREATION 
  include/mesos/authorizer/authorization.proto PRE-CREATION 
  include/mesos/authorizer/authorizer.hpp PRE-CREATION 
  include/mesos/mesos.proto 5ab3c4a305562af16af804e7ab77e576b96e468d 
  include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a 
  src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 
  src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f 
  src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc 
  src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 
  src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff 
  src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f 
  src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 
  src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
  src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
  src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 
  src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 
  src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 
  src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 
  src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a 

Diff: https://reviews.apache.org/r/36048/diff/


Testing
-------

make check


Thanks,

Alexander Rojas

Reply via email to