> On July 1, 2015, 5:41 a.m., Kapil Arya wrote: > > include/mesos/scheduler/scheduler.proto, lines 298-305 > > <https://reviews.apache.org/r/36078/diff/1/?file=996383#file996383line298> > > > > May be I am missing something here, but shouldn't we avoid changing the > > numbered tags for the message fields? > > > > This would mean that we should introduce Subscribe as: > > `optional Subscribe subscribe = 10'`.
Generally yes, but since the protos in this file haven't been exposed to users yet, I've been changing protobufs formats/tags without compatibility concerns. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/#review90009 ----------------------------------------------------------- On July 1, 2015, 5:23 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36078/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 5:23 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Ben Mahler. > > > Bugs: MESOs-2551 > https://issues.apache.org/jira/browse/MESOs-2551 > > > Repository: mesos > > > Description > ------- > > Subscribe message includes 'FrameworkInfo' and 'force'. Top level protobuf > has FrameworkID. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 249ec532b53fe428b7e66be4ced8223e66535b49 > src/examples/event_call_framework.cpp > 63e42bc83ccc0e4085d7619c478e5b010a49098a > src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 > src/sched/sched.cpp 7563abb85819b0b2bc9afdfd810b33c923c2522e > src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 > src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f > > Diff: https://reviews.apache.org/r/36078/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
