-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037/#review90102
-----------------------------------------------------------


Adding some minor test-based comments.


src/tests/call_tests.cpp (line 85)
<https://reviews.apache.org/r/36037/#comment143078>

    From the design doc : 
https://docs.google.com/document/d/1pnIY_HckimKNvpqhKRhbc9eSItWNFT-priXh_urR-T0/edit#
    
    We need to send back a "OK" with a PIPED stream as a response with the 
"Transfer-Encoding: chunked" header set. We need to test for the header too and 
the response status would not be a "Accepted" 202 here.



src/tests/call_tests.cpp (line 222)
<https://reviews.apache.org/r/36037/#comment143074>

    From the HTTP spec : "If no Accept header field is present, then it is 
assumed that the client accepts all media types", so this test is not valid.
    
    In essence , we need to test for an accept type which the server can't 
support that we already seem to be doing in CallEndpointWrongHeaderAccept, so 
we can delete this test.


- Anand Mazumdar


On July 1, 2015, 6:52 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36037/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-2860
>     https://issues.apache.org/jira/browse/MESOS-2860
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Adding a call route with HTTP request header validations
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3503833 
>   src/master/master.hpp af83d3e 
>   src/master/master.cpp 0782b54 
>   src/tests/call_tests.cpp PRE-CREATION 
>   src/tests/mesos.hpp 9157ac0 
> 
> Diff: https://reviews.apache.org/r/36037/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to