> On June 25, 2015, 8:25 a.m., Marco Massenzio wrote: > > src/master/master.cpp, line 2831 > > <https://reviews.apache.org/r/35855/diff/2/?file=991807#file991807line2831> > > > > not sure this is allowed in our code style, but this could be a good > > place for `nullptr` > > > > Also: shouldn't we LOG(ERROR) the fact that a given `offerId` results > > in a NULL ptr (in an `else` clause)?
since it is race, i did a LOG(WARNING). > On June 25, 2015, 8:25 a.m., Marco Massenzio wrote: > > src/tests/scheduler_tests.cpp, line 704 > > <https://reviews.apache.org/r/35855/diff/2/?file=991809#file991809line704> > > > > could this be more specific ("exactly" one)? yup. also made it an assert because it doesnt make sense to move forward otherwise. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/#review89331 ----------------------------------------------------------- On July 1, 2015, 5:24 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35855/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 5:24 a.m.) > > > Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and > Marco Massenzio. > > > Bugs: MESOS-2551 > https://issues.apache.org/jira/browse/MESOS-2551 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 > src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 > src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 > src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f > > Diff: https://reviews.apache.org/r/35855/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
