> On June 25, 2015, 6:25 p.m., Isabel Jimenez wrote:
> > src/master/master.hpp, line 1040
> > <https://reviews.apache.org/r/35857/diff/2/?file=991810#file991810line1040>
> >
> >     Is the purpose of moving this here to order Call handling methods? if 
> > yes, should we move revive too?

the order matches the protobuf order. not sure what you mean?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/#review89401
-----------------------------------------------------------


On July 1, 2015, 5:26 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35857/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 5:26 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and 
> Marco Massenzio.
> 
> 
> Bugs: MESOS-2551
>     https://issues.apache.org/jira/browse/MESOS-2551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
>   src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 
>   src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 
> 
> Diff: https://reviews.apache.org/r/35857/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> NOTE: Didn't add a new test because an existing test 
> (SchedulerTest.TaskRunning) already exercises this code path.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to