> On July 1, 2015, 11:19 p.m., Paul Brett wrote: > > src/linux/perf.cpp, line 456 > > <https://reviews.apache.org/r/36112/diff/1/?file=997702#file997702line456> > > > > Not your code but we should propagate the failure to the caller so that > > sample can fail rather than halt and catch fire here.
dropped this diff - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36112/#review90159 ----------------------------------------------------------- On July 1, 2015, 10:43 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36112/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 10:43 p.m.) > > > Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. > > > Bugs: MESOS-2834 > https://issues.apache.org/jira/browse/MESOS-2834 > > > Repository: mesos > > > Description > ------- > > perf: extracted out a 'version' function. > > > Diffs > ----- > > src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 > > Diff: https://reviews.apache.org/r/36112/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
