-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36114/#review90294
-----------------------------------------------------------



src/linux/perf.cpp (line 496)
<https://reviews.apache.org/r/36114/#comment143302>

    Sorry for the drive-by comment, but why not just have a single 'extract' 
that based on the 'Version' performs the necessary parsing?
    
    Exposing two 'extractv1' and 'extractv2' global functions seems a bit 
confusing (what are v1 and v2?). Would rather see them inlined, or you could 
have lambdas if you feel that they need to be self-contained.. :)


- Ben Mahler


On July 2, 2015, 11:40 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36114/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 11:40 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
> 
> 
> Bugs: mesos-2834
>     https://issues.apache.org/jira/browse/mesos-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> perf: added another extract function to support the new perf format after 
> v3.12.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 
> 
> Diff: https://reviews.apache.org/r/36114/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Reply via email to