Hey Mark,

First off, thanks for these patches! I appreciate you taking the time to
fix this.
Second, I think the review chain is reversed currently. The *stout* changes
should be the start of the chain, as it has the introduction of
*getOrElse* function.
So if you could flip it around to be *stout -> libprocess -> mesos*, I
think ReviewBot will be happier :)

Thanks,

MPark.

On Mon, Jul 6, 2015 at 1:08 PM Mesos ReviewBot <reviews@mesos.apache.org>
wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35287/#review90499
> -----------------------------------------------------------
>
>
> Bad patch!
>
> Reviews applied: [35285, 35286]
>
> Failed command: ./support/apply-review.sh -n -r 35286
>
> Error:
>  2015-07-06 17:08:20 URL:https://reviews.apache.org/r/35286/diff/raw/
> [1598/1598] -> "35286.patch" [1]
> error: patch failed: 3rdparty/libprocess/src/subprocess.cpp:327
> error: 3rdparty/libprocess/src/subprocess.cpp: patch does not apply
> Failed to apply patch
>
> - Mesos ReviewBot
>
>
> On July 6, 2015, 3:04 p.m., Mark Wang wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/35287/
> > -----------------------------------------------------------
> >
> > (Updated July 6, 2015, 3:04 p.m.)
> >
> >
> > Review request for mesos and Joris Van Remoortere.
> >
> >
> > Bugs: MESOS-2800
> >     https://issues.apache.org/jira/browse/MESOS-2800
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > -------
> >
> > Rename Option<T>::get(const T& _t) to getOrElse() and refactor original
> functions (stout)
> >
> >
> > Diffs
> > -----
> >
> >   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
> 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
> >   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp
> c8d30d8c193eb14f7accfde4fe02ce0710cd1817
> >   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
> f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
> >
> > Diff: https://reviews.apache.org/r/35287/diff/
> >
> >
> > Testing
> > -------
> >
> > make check
> >
> >
> > Thanks,
> >
> > Mark Wang
> >
> >
>
>

Reply via email to