-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36005/#review90552
-----------------------------------------------------------

Ship it!


LGTM. Mind adding to CHANGELOG that these have been removed?

- Vinod Kone


On June 29, 2015, 7:20 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36005/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 7:20 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2640
>     https://issues.apache.org/jira/browse/MESOS-2640
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   Makefile.am dcd0cb474944ae9c882e6cbdb64a33b4be5b9083 
>   configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 
>   docs/ec2-scripts.md 4866e2123eab0503bcc7fa130432bd41296d4b36 
>   docs/tools.md f485abb9ff498c4faf51a4b84b23f438da3fc0d1 
>   ec2/Makefile.am 8c64f485888df1599697eb181fc76aa83206da07 
>   ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/core-site.xml 
> 565f54dd933a89eb966fb8b01c589e1008d543bf 
>   ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hadoop-env.sh 
> 4e1e6991591e09f8860ab130948b0e787fce2b42 
>   ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hdfs-site.xml 
> 43e68aa3e2ecbb53bd3b0a99d33b11aadda2cca7 
>   ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/mapred-site.xml 
> b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b 
>   ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/masters 
> d26a1943aeb47ceeff904e593793e08c07eee9cc 
>   ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.amazon64-old/root/mesos-ec2/cluster-url 
> fcf8b41aed4b47a7b78d0c5a0042678f40059a5f 
>   ec2/deploy.amazon64-old/root/mesos-ec2/copy-dir 
> 02b6e642f6348b3b4cdc4ff5adb2b0070c1dc1cc 
>   ec2/deploy.amazon64-old/root/mesos-ec2/create-swap 
> 9ab32f841411f1053c29f0fa48f0cf2bbf468e82 
>   ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
> 818ed1030d3dd97467c4d4c83735cb7bda5afa80 
>   ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
> ca227b460e9d6b89a2fe3692a74eb1c267bc7b7f 
>   
> ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
> 0ffa92f115d66adc9e370f4030850216545ade38 
>   
> ec2/deploy.amazon64-old/root/mesos-ec2/haproxy+apache/haproxy.config.template 
> 957c3f6a6b2a2f658e076337d88e69447b2a3341 
>   ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/Capfile 
> fd5921e57d7985e128622ed132c9a24c7cd21d1b 
>   ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/hypertable.cfg 
> b4d5b7475fab3d4a842e4b0f459abc5ca316996a 
>   ec2/deploy.amazon64-old/root/mesos-ec2/masters 
> c531652dc1ef9e6d6ca73cec389b6433f35ae9cf 
>   ec2/deploy.amazon64-old/root/mesos-ec2/mesos-daemon 
> 20ec099f521c97af569b98555ef67964cdcf97cc 
>   ec2/deploy.amazon64-old/root/mesos-ec2/redeploy-mesos 
> 941d783d82f0708a6da0f4677c3364537dfded63 
>   ec2/deploy.amazon64-old/root/mesos-ec2/setup 
> 2165f90139d179d57b3d3b243d96fbea20a50b2c 
>   ec2/deploy.amazon64-old/root/mesos-ec2/setup-slave 
> 436f417bc5a746ad74cc88c27e630a91d55b0b23 
>   ec2/deploy.amazon64-old/root/mesos-ec2/setup-torque 
> 2ac8fd3546063d3ba391147383de53b7824c7c8c 
>   ec2/deploy.amazon64-old/root/mesos-ec2/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.amazon64-old/root/mesos-ec2/ssh-no-keychecking 
> 3daf46fe988b4b7dac4879f4ea31b6ffca1dc02a 
>   ec2/deploy.amazon64-old/root/mesos-ec2/start-hypertable 
> af16c2d7bd615cb0c98f6ba65ff5c69859678850 
>   ec2/deploy.amazon64-old/root/mesos-ec2/start-mesos 
> cc309cc44ecf5b67536f275083dca22948926f6b 
>   ec2/deploy.amazon64-old/root/mesos-ec2/stop-hypertable 
> 7280dc11bfc53ae84b7ecaba34c84810461ed7f4 
>   ec2/deploy.amazon64-old/root/mesos-ec2/stop-mesos 
> 9fdb8753dffc5115f94582753e0860538be6232b 
>   ec2/deploy.amazon64-old/root/mesos-ec2/zoo 
> efc961b502f30a6f187f7e50c2b92b302203d89e 
>   ec2/deploy.amazon64-old/root/persistent-hdfs/conf/core-site.xml 
> b23aef258a13e4bc4cbf27099f7aa68419ab0825 
>   ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hadoop-env.sh 
> b38ba01817e3b9c9715a476ecb692bac68983f50 
>   ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hdfs-site.xml 
> ec000cb2f306232a29cf701b10f230685d2662c9 
>   ec2/deploy.amazon64-old/root/persistent-hdfs/conf/mapred-site.xml 
> b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b 
>   ec2/deploy.amazon64-old/root/persistent-hdfs/conf/masters 
> d26a1943aeb47ceeff904e593793e08c07eee9cc 
>   ec2/deploy.amazon64-old/root/persistent-hdfs/conf/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.amazon64-old/root/spark/conf/spark-env.sh 
> 86da7f832d03dfc6cc0be5e479fea7d8f92541e0 
>   ec2/deploy.amazon64/root/ephemeral-hdfs/conf/core-site.xml 
> 565f54dd933a89eb966fb8b01c589e1008d543bf 
>   ec2/deploy.amazon64/root/ephemeral-hdfs/conf/hadoop-env.sh 
> 4e1e6991591e09f8860ab130948b0e787fce2b42 
>   ec2/deploy.amazon64/root/ephemeral-hdfs/conf/hdfs-site.xml 
> 43e68aa3e2ecbb53bd3b0a99d33b11aadda2cca7 
>   ec2/deploy.amazon64/root/ephemeral-hdfs/conf/mapred-site.xml 
> b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b 
>   ec2/deploy.amazon64/root/ephemeral-hdfs/conf/masters 
> d26a1943aeb47ceeff904e593793e08c07eee9cc 
>   ec2/deploy.amazon64/root/ephemeral-hdfs/conf/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.amazon64/root/mesos-ec2/cluster-url 
> fcf8b41aed4b47a7b78d0c5a0042678f40059a5f 
>   ec2/deploy.amazon64/root/mesos-ec2/copy-dir 
> 02b6e642f6348b3b4cdc4ff5adb2b0070c1dc1cc 
>   ec2/deploy.amazon64/root/mesos-ec2/create-swap 
> 9ab32f841411f1053c29f0fa48f0cf2bbf468e82 
>   ec2/deploy.amazon64/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
> 818ed1030d3dd97467c4d4c83735cb7bda5afa80 
>   ec2/deploy.amazon64/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
> d8483140546fe00d6d17494c14ef4b09ae368496 
>   ec2/deploy.amazon64/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
> 0ffa92f115d66adc9e370f4030850216545ade38 
>   ec2/deploy.amazon64/root/mesos-ec2/haproxy+apache/haproxy.config.template 
> 957c3f6a6b2a2f658e076337d88e69447b2a3341 
>   ec2/deploy.amazon64/root/mesos-ec2/hypertable/Capfile 
> fd5921e57d7985e128622ed132c9a24c7cd21d1b 
>   ec2/deploy.amazon64/root/mesos-ec2/hypertable/hypertable.cfg 
> b4d5b7475fab3d4a842e4b0f459abc5ca316996a 
>   ec2/deploy.amazon64/root/mesos-ec2/masters 
> c531652dc1ef9e6d6ca73cec389b6433f35ae9cf 
>   ec2/deploy.amazon64/root/mesos-ec2/mesos-daemon 
> bed27657f8718eecafb83cca5d29e0612a87f129 
>   ec2/deploy.amazon64/root/mesos-ec2/redeploy-mesos 
> 941d783d82f0708a6da0f4677c3364537dfded63 
>   ec2/deploy.amazon64/root/mesos-ec2/setup 
> c69f7da8e730f582096cc81a64b9e6812f75cf55 
>   ec2/deploy.amazon64/root/mesos-ec2/setup-slave 
> 436f417bc5a746ad74cc88c27e630a91d55b0b23 
>   ec2/deploy.amazon64/root/mesos-ec2/setup-torque 
> 2ac8fd3546063d3ba391147383de53b7824c7c8c 
>   ec2/deploy.amazon64/root/mesos-ec2/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.amazon64/root/mesos-ec2/ssh-no-keychecking 
> 3daf46fe988b4b7dac4879f4ea31b6ffca1dc02a 
>   ec2/deploy.amazon64/root/mesos-ec2/start-hypertable 
> af16c2d7bd615cb0c98f6ba65ff5c69859678850 
>   ec2/deploy.amazon64/root/mesos-ec2/start-mesos 
> 0f551db396fa7ffebef880dca0232c22808ff7cc 
>   ec2/deploy.amazon64/root/mesos-ec2/stop-hypertable 
> 7280dc11bfc53ae84b7ecaba34c84810461ed7f4 
>   ec2/deploy.amazon64/root/mesos-ec2/stop-mesos 
> 9fdb8753dffc5115f94582753e0860538be6232b 
>   ec2/deploy.amazon64/root/mesos-ec2/zoo 
> efc961b502f30a6f187f7e50c2b92b302203d89e 
>   ec2/deploy.amazon64/root/persistent-hdfs/conf/core-site.xml 
> b23aef258a13e4bc4cbf27099f7aa68419ab0825 
>   ec2/deploy.amazon64/root/persistent-hdfs/conf/hadoop-env.sh 
> b38ba01817e3b9c9715a476ecb692bac68983f50 
>   ec2/deploy.amazon64/root/persistent-hdfs/conf/hdfs-site.xml 
> ec000cb2f306232a29cf701b10f230685d2662c9 
>   ec2/deploy.amazon64/root/persistent-hdfs/conf/mapred-site.xml 
> b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b 
>   ec2/deploy.amazon64/root/persistent-hdfs/conf/masters 
> d26a1943aeb47ceeff904e593793e08c07eee9cc 
>   ec2/deploy.amazon64/root/persistent-hdfs/conf/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.amazon64/root/spark/conf/spark-env.sh 
> 6b331ff2257d1b88c8ebe2e8095887a3e2cf0d54 
>   ec2/deploy.centos64/root/ephemeral-hdfs/conf/core-site.xml 
> 565f54dd933a89eb966fb8b01c589e1008d543bf 
>   ec2/deploy.centos64/root/ephemeral-hdfs/conf/hadoop-env.sh 
> fc122f0fdfddc6a342e634cdbc2e1537fce9d9c1 
>   ec2/deploy.centos64/root/ephemeral-hdfs/conf/hdfs-site.xml 
> 46318c7c30c5cfe771e7882a9b4153d15fd70151 
>   ec2/deploy.centos64/root/ephemeral-hdfs/conf/mapred-site.xml 
> b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b 
>   ec2/deploy.centos64/root/ephemeral-hdfs/conf/masters 
> d26a1943aeb47ceeff904e593793e08c07eee9cc 
>   ec2/deploy.centos64/root/ephemeral-hdfs/conf/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.centos64/root/mesos-ec2/cluster-url 
> fcf8b41aed4b47a7b78d0c5a0042678f40059a5f 
>   ec2/deploy.centos64/root/mesos-ec2/copy-dir 
> 02b6e642f6348b3b4cdc4ff5adb2b0070c1dc1cc 
>   ec2/deploy.centos64/root/mesos-ec2/create-swap 
> dc4d13f36b66e412bcf4e2a7d6c3e4888a27c958 
>   ec2/deploy.centos64/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
> 818ed1030d3dd97467c4d4c83735cb7bda5afa80 
>   ec2/deploy.centos64/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
> ca227b460e9d6b89a2fe3692a74eb1c267bc7b7f 
>   ec2/deploy.centos64/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
> 0ffa92f115d66adc9e370f4030850216545ade38 
>   ec2/deploy.centos64/root/mesos-ec2/haproxy+apache/haproxy.config.template 
> 957c3f6a6b2a2f658e076337d88e69447b2a3341 
>   ec2/deploy.centos64/root/mesos-ec2/hypertable/Capfile 
> e30997150d67fc7328062245005f3dd94e7af075 
>   ec2/deploy.centos64/root/mesos-ec2/hypertable/hypertable.cfg 
> 934897a7d7fa953ba363ef04b177c1db9d4e7fab 
>   ec2/deploy.centos64/root/mesos-ec2/masters 
> c531652dc1ef9e6d6ca73cec389b6433f35ae9cf 
>   ec2/deploy.centos64/root/mesos-ec2/mesos-daemon 
> 177265eb8d025c15ff68f973af347bb95cd0d1fe 
>   ec2/deploy.centos64/root/mesos-ec2/redeploy-mesos 
> 941d783d82f0708a6da0f4677c3364537dfded63 
>   ec2/deploy.centos64/root/mesos-ec2/setup 
> f06ed21bee36555c868061e7c7d434216ccc0258 
>   ec2/deploy.centos64/root/mesos-ec2/setup-slave 
> bbb8d34ece29a4f3f6aef06fc476337d8b3af540 
>   ec2/deploy.centos64/root/mesos-ec2/setup-torque 
> 2ac8fd3546063d3ba391147383de53b7824c7c8c 
>   ec2/deploy.centos64/root/mesos-ec2/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.centos64/root/mesos-ec2/ssh-no-keychecking 
> 3daf46fe988b4b7dac4879f4ea31b6ffca1dc02a 
>   ec2/deploy.centos64/root/mesos-ec2/start-hypertable 
> 0e2593f66b34cd39730b05d5e84a000945510749 
>   ec2/deploy.centos64/root/mesos-ec2/start-mesos 
> cc309cc44ecf5b67536f275083dca22948926f6b 
>   ec2/deploy.centos64/root/mesos-ec2/stop-hypertable 
> 7280dc11bfc53ae84b7ecaba34c84810461ed7f4 
>   ec2/deploy.centos64/root/mesos-ec2/stop-mesos 
> 9fdb8753dffc5115f94582753e0860538be6232b 
>   ec2/deploy.centos64/root/mesos-ec2/zoo 
> efc961b502f30a6f187f7e50c2b92b302203d89e 
>   ec2/deploy.centos64/root/persistent-hdfs/conf/core-site.xml 
> b23aef258a13e4bc4cbf27099f7aa68419ab0825 
>   ec2/deploy.centos64/root/persistent-hdfs/conf/hadoop-env.sh 
> 854c61f1af772c84a54ef6ae78442dc4844e9e73 
>   ec2/deploy.centos64/root/persistent-hdfs/conf/hdfs-site.xml 
> 86c9f78801218581d0d6f139b87522a1c4edaf45 
>   ec2/deploy.centos64/root/persistent-hdfs/conf/mapred-site.xml 
> b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b 
>   ec2/deploy.centos64/root/persistent-hdfs/conf/masters 
> d26a1943aeb47ceeff904e593793e08c07eee9cc 
>   ec2/deploy.centos64/root/persistent-hdfs/conf/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.generic/root/mesos-ec2/ec2-variables.sh 
> 1f76e61b2feffa4eadc53745caa5033dde182531 
>   ec2/deploy.lucid64/root/hadoop-0.20.2/conf/core-site.xml 
> 0fc1402c1ae5f0813177ee1713573b9f10dcd325 
>   ec2/deploy.lucid64/root/hadoop-0.20.2/conf/hadoop-env.sh 
> bfd431e1d96806675fbf404a6217f76ae7abe6a4 
>   ec2/deploy.lucid64/root/hadoop-0.20.2/conf/hdfs-site.xml 
> 46318c7c30c5cfe771e7882a9b4153d15fd70151 
>   ec2/deploy.lucid64/root/hadoop-0.20.2/conf/masters 
> d26a1943aeb47ceeff904e593793e08c07eee9cc 
>   ec2/deploy.lucid64/root/hadoop-0.20.2/conf/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.lucid64/root/mesos-ec2/cluster-url 
> fcf8b41aed4b47a7b78d0c5a0042678f40059a5f 
>   ec2/deploy.lucid64/root/mesos-ec2/copy-dir 
> 02b6e642f6348b3b4cdc4ff5adb2b0070c1dc1cc 
>   ec2/deploy.lucid64/root/mesos-ec2/hadoop-framework-conf/core-site.xml 
> 818ed1030d3dd97467c4d4c83735cb7bda5afa80 
>   ec2/deploy.lucid64/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh 
> 811f4030ea5b1a8589b41374519ed9b0a99d756d 
>   ec2/deploy.lucid64/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 
> 8d6240c19c52d83a530563b1ec9f01c3bd3187cc 
>   ec2/deploy.lucid64/root/mesos-ec2/haproxy+apache/haproxy.config.template 
> 957c3f6a6b2a2f658e076337d88e69447b2a3341 
>   ec2/deploy.lucid64/root/mesos-ec2/masters 
> c531652dc1ef9e6d6ca73cec389b6433f35ae9cf 
>   ec2/deploy.lucid64/root/mesos-ec2/mesos-daemon 
> 177265eb8d025c15ff68f973af347bb95cd0d1fe 
>   ec2/deploy.lucid64/root/mesos-ec2/redeploy-mesos 
> 941d783d82f0708a6da0f4677c3364537dfded63 
>   ec2/deploy.lucid64/root/mesos-ec2/setup 
> cd11d65254fa03a066994537b7bfd0f16ccb2622 
>   ec2/deploy.lucid64/root/mesos-ec2/setup-slave 
> 519219319d3e6cdaf88c63fc0937c1737e431b17 
>   ec2/deploy.lucid64/root/mesos-ec2/setup-torque 
> 2ac8fd3546063d3ba391147383de53b7824c7c8c 
>   ec2/deploy.lucid64/root/mesos-ec2/slaves 
> 05f969e0c667629041099e97dd8d6a8168e211a1 
>   ec2/deploy.lucid64/root/mesos-ec2/ssh-no-keychecking 
> 3daf46fe988b4b7dac4879f4ea31b6ffca1dc02a 
>   ec2/deploy.lucid64/root/mesos-ec2/start-mesos 
> cc309cc44ecf5b67536f275083dca22948926f6b 
>   ec2/deploy.lucid64/root/mesos-ec2/stop-mesos 
> 9fdb8753dffc5115f94582753e0860538be6232b 
>   ec2/deploy.lucid64/root/mesos-ec2/zoo 
> efc961b502f30a6f187f7e50c2b92b302203d89e 
>   ec2/mesos-ec2 e3c0c14fe26d260c39f44d3779c41e9b32436fc0 
>   ec2/mesos_ec2.py 15d85b52cc58c8efaf7a8b771b4d5616282cf3b7 
> 
> Diff: https://reviews.apache.org/r/36005/diff/
> 
> 
> Testing
> -------
> 
> make check. The scripts are not referenced from elsewhere in the codebase and 
> the doc ec2-scripts.md is not linked from the website.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to