-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/#review90741
-----------------------------------------------------------

Ship it!


Looks great! Fix the log message and I'll commit it.


src/common/attributes.cpp (line 154)
<https://reviews.apache.org/r/35986/#comment143873>

    `pairs[0]` is not accurate if it was pairs[1] that was empty, and printing 
an empty string is pointless anyway.
    How about `LOG(FATAL) << "Invalid attribute key:value pair '" << tokens[i] 
<< "'";` so that the error shows the leading/trailing ':'



src/tests/attributes_tests.cpp (lines 55 - 63)
<https://reviews.apache.org/r/35986/#comment143875>

    These could be combined easily enough.


- Adam B


On July 7, 2015, 10:55 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35986/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:55 a.m.)
> 
> 
> Review request for mesos, Adam B and Isabel Jimenez.
> 
> 
> Bugs: MESOS-2868
>     https://issues.apache.org/jira/browse/MESOS-2868
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow slave attributes flag take a value with ':'.
> 
> 
> Diffs
> -----
> 
>   src/common/attributes.cpp aab114e1a5932e3f218b850e1afc7f2ef0f10e21 
>   src/tests/attributes_tests.cpp 2e10eaf3c33e418603ea19090bb0bf9179af71f7 
> 
> Diff: https://reviews.apache.org/r/35986/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to