> On July 2, 2015, 11:32 p.m., Ben Mahler wrote: > > src/linux/cgroups.hpp, lines 443-472 > > <https://reviews.apache.org/r/36106/diff/1/?file=997646#file997646line443> > > > > Thanks! > > > > (1) Do you mind updating my TODO on cgroups::stat() to reflect that > > cpuacct::stat is implemented? > > > > (2) Can we just make this a simple struct with two non-const fields and > > remove the parse method and getters? Keep it simple and small, if we want > > immutability we can just have a 'const Stat' rather than forcing it on the > > caller :) > > > > (3) Any reason not to use 'Duration' for these fields? > > Jojy Varghese wrote: > 1) Absolutely I can. > 2) I wanted to reflect the semantics of the stats call. When you make a > stats call, the data you get is immutable. By forcing external const, it > would imply that the value is immutable. > 3) Duration is a "period" ( i think) and the values here are absolute > values derived from ticks. > > Joris Van Remoortere wrote: > Regarding 3): > Duration indeed represents an amount of time, rather than a specific > point in time. I believe this is what we intend to represent in this code as > well, right? The comments for your functions suggest an amount of time rather > than a point in time.
Regarding 1): I am working on another patch that addresses the containerizer (docker) using this API. I will also change the cpushare code along with that patch. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90288 ----------------------------------------------------------- On July 7, 2015, 12:26 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36106/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 12:26 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Joris Van Remoortere, and > Timothy Chen. > > > Bugs: MESOS-2961 > https://issues.apache.org/jira/browse/MESOS-2961 > > > Repository: mesos > > > Description > ------- > > cgroups implementation does not have a cpuacct subsystem implementation as of > today. Adding the implementation for stat function. > > Changes: > - added Stats class to encapsulate cpuacct.stat data > - added implementation for cpuacct::stats > - added unit tests > > Jira: MESOS-2961 > > > Diffs > ----- > > src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 > src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 > src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a > > Diff: https://reviews.apache.org/r/36106/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
