----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35777/ -----------------------------------------------------------
(Updated July 8, 2015, 9:18 p.m.) Review request for mesos, Benjamin Hindman, Marco Massenzio, and Till Toenshoff. Changes ------- Addressed Marco and Vinod's comments. Repository: mesos Description (updated) ------- Handles the case where the ReviewBoard URL is invalid. ``` af081a07234794f60a2575e0383ce537d7111c18 - Fixed post-reviews.py hanging bug. (29 seconds ago) Invalid ReviewBoard URL : 'https://reviews.apache.org/r/35771 abcd' ``` Reads `REVIEWBOARD_URL` from `.reviewboardrc` if it's available. We use `imp.load_source` to import the `.reviewboardrc` file. > __.reviewboardrc__ > > The .reviewboardrc file is a generic place for configuring a repository. This > must be in a directory in the user’s checkout path to work. __It must parse > as a valid Python file__, or you’ll see an error when using rbt. Diffs (updated) ----- support/post-reviews.py b04e26b85e6b056098c15078f9b31dc352682351 Diff: https://reviews.apache.org/r/35777/diff/ Testing ------- Modified the commit message with `git rebase` and ran `./support/post-reviews.py` to observe the above error messages. Used the valid commit message for this patch and created it by running `./support/post-reviews.py`. Thanks, Michael Park
