-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36326/#review91005
-----------------------------------------------------------



src/slave/containerizer/docker.hpp (line 230)
<https://reviews.apache.org/r/36326/#comment144203>

    I dont' think we need to expose this.



src/slave/containerizer/docker.cpp (line 1239)
<https://reviews.apache.org/r/36326/#comment144201>

    It's probably not going to be used outside of usage, so I think it's safe 
to inline this in _usage, and if you do want a seperate method this probably 
don't need to be exposed too.



src/slave/containerizer/isolators/cgroups/cpushare.cpp 
<https://reviews.apache.org/r/36326/#comment144202>

    Let's try to make a seperate rb for touching cpushare, and another rb for 
just updating docker containerizer to use this.


- Timothy Chen


On July 8, 2015, 9:40 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36326/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 9:40 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2951
>     https://issues.apache.org/jira/browse/MESOS-2951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP
> 
> Adding cgroups cpustat and memory statistics as preferred way to get usage
> statistics for containerizers.
> 
> Jira: MESOS-2951
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 646a277be21deaded47324bea5474bd68699f25f 
>   src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 
> f56e97dcf91a6f5c9a8abe4afe9dc1a1d47df330 
> 
> Diff: https://reviews.apache.org/r/36326/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to