----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36336/#review91047 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line 35) <https://reviews.apache.org/r/36336/#comment144301> Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format. - Kapil Arya On July 8, 2015, 6:50 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36336/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 6:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, > Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-3020 > https://issues.apache.org/jira/browse/MESOS-3020 > > > Repository: mesos > > > Description > ------- > > Expose major, minor and patch components from stout Version > > Note: The names major and minor are not available when compiling with GCC > because it pulls in the sysmacros.h header implicitly which define these for > makedev. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp > 8692323d28131cd5706dde0503d49f8f0b0a1aeb > > Diff: https://reviews.apache.org/r/36336/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
