----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91113 -----------------------------------------------------------
src/master/http.cpp (lines 124 - 125) <https://reviews.apache.org/r/35687/#comment144379> were you not able to use 'foreach' here? foreach(FrameworkInfo::Capability& capability, framework.info.capabilities()) { } src/tests/master_tests.cpp (lines 2994 - 2996) <https://reviews.apache.org/r/35687/#comment144380> pull this below #2998 so that webui_url testing is all in one block. also, you captured 'Capability' into an JSON::array but doing nothing with it? did you forget to add an EXPECT_EQ to make sure this value is the same as the one you added in #2958? - Vinod Kone On July 9, 2015, 4:04 p.m., Aditi Dixit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35687/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 4:04 p.m.) > > > Review request for mesos, Marco Massenzio and Vinod Kone. > > > Bugs: MESOS-2900 > https://issues.apache.org/jira/browse/MESOS-2900 > > > Repository: mesos > > > Description > ------- > > Added capabilities to state.json and test for the same > > > Diffs > ----- > > src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 > src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 > > Diff: https://reviews.apache.org/r/35687/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Aditi Dixit > >
