> On July 9, 2015, 8:23 p.m., Anand Mazumdar wrote:
> > src/common/http_constants.cpp, line 26
> > <https://reviews.apache.org/r/36360/diff/1/?file=1003774#file1003774line26>
> >
> >     minor nit-pick , might consider using std::string; before-hand ?

:) done


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91178
-----------------------------------------------------------


On July 9, 2015, 9:07 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36360/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-2860
>     https://issues.apache.org/jira/browse/MESOS-2860
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Adding constants used commonly through the different HTTP endpoints
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e5b5d36 
>   src/common/http_constants.hpp PRE-CREATION 
>   src/common/http_constants.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to