> On July 4, 2015, 5:34 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 282 > > <https://reviews.apache.org/r/36181/diff/1/?file=999124#file999124line282> > > > > These flags are supported only after a certain docker version right? > > > > I think we need to log and disable this when the user is using a older > > version that doens't support these flags. > > haosdent huang wrote: > Is it possible to support cfs in older docker? Maybe we could change to > that way.
@tnachen, I return error when start the slave, or just need warning and disable it when start slave? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/#review90392 ----------------------------------------------------------- On July 11, 2015, 8:59 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36181/ > ----------------------------------------------------------- > > (Updated July 11, 2015, 8:59 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2154 > https://issues.apache.org/jira/browse/MESOS-2154 > > > Repository: mesos > > > Description > ------- > > Port CFS support to Docker Containerizer > > > Diffs > ----- > > src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f > > Diff: https://reviews.apache.org/r/36181/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
