----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review91492 -----------------------------------------------------------
docs/configuration.md (line 92) <https://reviews.apache.org/r/36425/#comment144889> Default isn't quite correct here. More accurate is `Mesos will do a lookup of the machine's hostname to try and figure out what IP address to use` src/master/main.cpp (line 22) <https://reviews.apache.org/r/36425/#comment144891> Please use <stdlib.h> or use the <c*> variants consistently src/master/main.cpp (line 35) <https://reviews.apache.org/r/36425/#comment144893> unused include src/master/main.cpp (line 39) <https://reviews.apache.org/r/36425/#comment144894> unused include src/master/main.cpp (line 148) <https://reviews.apache.org/r/36425/#comment144895> Supersedes -> Overrides like you did in the docs? src/master/main.cpp (line 211) <https://reviews.apache.org/r/36425/#comment144899> Could you add a basic "Can we change this discoveredIp -> an actual IP address" check here? The error message when LIBPROCESS_IP ends up incorrect inside libprocess is going to not say very cleanly where that value came from, and I suspect when doing iteration it will be fairly common for people to write IP scripts which give incorrect / invalid output. - Cody Maloney On July 13, 2015, 4:35 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36425/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 4:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Cody Maloney. > > > Bugs: MESOS-2902 > https://issues.apache.org/jira/browse/MESOS-2902 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2902 > > It is sometimes useful to enable an external script to > configure the IP address the Mesos Master will bind to > on the server, where it's not desirable to set the > --ip flag and/or a "wrapper" script is not a viable option. > > This patch adds a --ip_discovery_script to point to a local > script that will emit as its only output the IP address that > the Master will bind to: only spaces and newlines are allowed; > further, as we cannot use the `libprocess` sub-processing > facilities, we cannot timeout the script, should this block > for long times (or even forever). > > This will override the --ip flag, which, even if set, will be > ignored. > > > Diffs > ----- > > docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01 > src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 > > Diff: https://reviews.apache.org/r/36425/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >