> On July 10, 2015, 9:43 p.m., Ian Downes wrote:
> > src/tests/perf_tests.cpp, line 159
> > <https://reviews.apache.org/r/36380/diff/2/?file=1008562#file1008562line159>
> >
> >     Do you need to keep all the logging of the context  on failed 
> > expectations after the test has been correctly written? It clutters the 
> > code...

If you remove it, you cant tell which test failed so it becomes necessary to 
re-add it if you ever get a failure.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36380/#review91346
-----------------------------------------------------------


On July 10, 2015, 8:52 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36380/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 8:52 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-2834
>     https://issues.apache.org/jira/browse/MESOS-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test cases for performance monitor support of multiple output versions 
> depending on kernel version.
> 
> 
> Diffs
> -----
> 
>   src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 
> 
> Diff: https://reviews.apache.org/r/36380/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to