----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36464/#review91764 -----------------------------------------------------------
Ship it! Looks good but mind removing the deprecated code in a different review? src/sched/sched.cpp (line 922) <https://reviews.apache.org/r/36464/#comment145395> add a space between foreach and the open paren src/sched/sched.cpp <https://reviews.apache.org/r/36464/#comment145394> Mind pulling this patch out into a separate review? Seems independent :) src/tests/master_tests.cpp (lines 2566 - 2567) <https://reviews.apache.org/r/36464/#comment145393> Is the mesos:: prefix needed? - Ben Mahler On July 13, 2015, 11:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36464/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 11:59 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2913 > https://issues.apache.org/jira/browse/MESOS-2913 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d > src/tests/master_tests.cpp 57721b788d0c70f4c6f5cc44d87465f52a70b6c2 > > Diff: https://reviews.apache.org/r/36464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
