----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36466/#review91766 -----------------------------------------------------------
Ship it! src/sched/sched.cpp (line 1135) <https://reviews.apache.org/r/36466/#comment145399> newline before like your other reviews? Seems like setting type should be in a different block than setting the framework id, more related to the line below where you grab a 'Reconcile' from the call src/tests/reconciliation_tests.cpp (lines 451 - 452) <https://reviews.apache.org/r/36466/#comment145402> Is mesos:: needed? src/tests/reconciliation_tests.cpp (lines 592 - 593) <https://reviews.apache.org/r/36466/#comment145403> Is mesos:: needed? - Ben Mahler On July 14, 2015, 12:01 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36466/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 12:01 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2913 > https://issues.apache.org/jira/browse/MESOS-2913 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d > src/tests/reconciliation_tests.cpp 6042d8c02d86f486e0c4d82d5a70666d7ac9019b > > Diff: https://reviews.apache.org/r/36466/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
