-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36467/#review91767
-----------------------------------------------------------

Ship it!



src/sched/sched.cpp (line 745)
<https://reviews.apache.org/r/36467/#comment145404>

    Ditto other reviews, mind adding a newline here? Seems unrelated to setting 
framework id.



src/sched/sched.cpp 
<https://reviews.apache.org/r/36467/#comment145405>

    Whoops, there is a call to master.get() in the VLOG line, that's why it was 
up here. Mind moving it back up?



src/sched/sched.cpp (line 1076)
<https://reviews.apache.org/r/36467/#comment145406>

    Ditto adding a newline.



src/tests/fault_tolerance_tests.cpp (lines 1299 - 1300)
<https://reviews.apache.org/r/36467/#comment145407>

    Is mesos:: needed?



src/tests/reconciliation_tests.cpp (lines 748 - 751)
<https://reviews.apache.org/r/36467/#comment145408>

    Is mesos:: needed?



src/tests/scheduler_tests.cpp (lines 1033 - 1037)
<https://reviews.apache.org/r/36467/#comment145409>

    Is mesos:: needed? Ditto for the rest of this file.



src/tests/slave_recovery_tests.cpp (lines 216 - 217)
<https://reviews.apache.org/r/36467/#comment145411>

    Is mesos:: needed?



src/tests/slave_recovery_tests.cpp (lines 318 - 319)
<https://reviews.apache.org/r/36467/#comment145412>

    Shall we store the 'uuid' in a variable to make this a bit easier to read?



src/tests/status_update_manager_tests.cpp (lines 423 - 426)
<https://reviews.apache.org/r/36467/#comment145413>

    Is mesos:: needed?


- Ben Mahler


On July 14, 2015, 12:18 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36467/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 12:18 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2913
>     https://issues.apache.org/jira/browse/MESOS-2913
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d 
>   src/tests/fault_tolerance_tests.cpp 
> 1070ccf17f98f6b3800684a5edd6517d90631c3e 
>   src/tests/reconciliation_tests.cpp 6042d8c02d86f486e0c4d82d5a70666d7ac9019b 
>   src/tests/scheduler_tests.cpp 946fa8245d8ab35e04bad642d69114caf0ccf6a9 
>   src/tests/slave_recovery_tests.cpp 2f882cf7b4235583b0ec8397cfcbbc02930fbc88 
>   src/tests/slave_tests.cpp 4ddc608ab9636fcc0166e8c80a252dcf67b45ad3 
>   src/tests/status_update_manager_tests.cpp 
> 440b07475e28dc491ab640acaca8ee20db8411f8 
> 
> Diff: https://reviews.apache.org/r/36467/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to