----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91823 -----------------------------------------------------------
src/tests/utils.hpp (line 55) <https://reviews.apache.org/r/36501/#comment145460> * Tab size = 2 spaces. * Parameters are indented by 4 spaces. * Comments start with a capital letter and end with a period. * Logical blocks have the opening "{" on the same line. - Joseph Wu On July 14, 2015, 7:59 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36501/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 7:59 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3023 > https://issues.apache.org/jira/browse/MESOS-3023 > > > Repository: mesos > > > Description > ------- > > Fix for MESOS-3023 (Factoring out the pattern for URL generation) > > > Diffs > ----- > > src/tests/fetcher_tests.cpp ae10c420f7dddb8650377c91b5343591e8560392 > src/tests/utils.hpp f2eed2e6fbc2cc8772c642bba976b25b426784e8 > > Diff: https://reviews.apache.org/r/36501/diff/ > > > Testing > ------- > > 1. Build successfully in Linux > 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest > > > Thanks, > > Klaus Ma > >