-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36488/#review91840
-----------------------------------------------------------


Looks great! Helped me understand the feature much better. Comments below.


docs/oversubscription.md (line 5)
<https://reviews.apache.org/r/36488/#comment145484>

    I find "Online" confusing.
    How about "High-priority user-facing services..."? (then it also ties into 
the "low-priority jobs" you mention at the end of the paragraph.



docs/oversubscription.md (lines 7 - 8)
<https://reviews.apache.org/r/36488/#comment145485>

    "Oversubscription takes advantage..."



docs/oversubscription.md (line 15)
<https://reviews.apache.org/r/36488/#comment145487>

    s/QoS/Quality of Service (QoS)/ just to introduce the term.



docs/oversubscription.md (line 19)
<https://reviews.apache.org/r/36488/#comment145488>

    In the image text,
    6) s/doesn't/don't/



docs/oversubscription.md (line 28)
<https://reviews.apache.org/r/36488/#comment145489>

    Define 'slack'?



docs/oversubscription.md (lines 28 - 29)
<https://reviews.apache.org/r/36488/#comment145490>

    Should (2) go in its own bullet item?



docs/oversubscription.md (line 36)
<https://reviews.apache.org/r/36488/#comment145503>

    What types of resources can be oversubscribed? Just cpu and memory? What 
about disk? Ports? Custom resource types (bananas)?



docs/oversubscription.md (line 37)
<https://reviews.apache.org/r/36488/#comment145492>

    s/the offer/those offers/?
    Also, can you provide an example Resource message with 'revocable' set?



docs/oversubscription.md (lines 41 - 42)
<https://reviews.apache.org/r/36488/#comment145502>

    Can you dynamically reserve revocable resources?
    Can you create persistent volumes out of revocable disk resources?



docs/oversubscription.md (line 73)
<https://reviews.apache.org/r/36488/#comment145504>

    "issue revocable offers to this framework."



docs/oversubscription.md (lines 75 - 76)
<https://reviews.apache.org/r/36488/#comment145505>

    As an operator, how do I enable oversubscription then? Maybe add "See below 
for instructions for Configuring Mesos for Oversubscription", or reorder these?



docs/oversubscription.md (line 80)
<https://reviews.apache.org/r/36488/#comment145506>

    s/That be, frameworks/Thus, a framework/



docs/oversubscription.md (line 82)
<https://reviews.apache.org/r/36488/#comment145507>

    s/for regular and revocable resources separately./separately for regular 
and revocable resources./



docs/oversubscription.md (line 83)
<https://reviews.apache.org/r/36488/#comment145508>

    s/have/has/



docs/oversubscription.md (line 91)
<https://reviews.apache.org/r/36488/#comment145515>

    Noop too?



docs/oversubscription.md (lines 121 - 124)
<https://reviews.apache.org/r/36488/#comment145516>

    You said exactly the same thing above in (6). Do you need to repeat 
yourself? What specific info do you want in each section?



docs/oversubscription.md (line 153)
<https://reviews.apache.org/r/36488/#comment145517>

    Is this currently the only type? What about THROTTLE?



docs/oversubscription.md (line 166)
<https://reviews.apache.org/r/36488/#comment145521>

    s/the Mesos/Mesos/
    Is there a switch to globally disable the feature from the master?
    Can some slaves enable it while others don't?



docs/oversubscription.md (line 168)
<https://reviews.apache.org/r/36488/#comment145524>

    I count 5 flags, not 3.



docs/oversubscription.md (line 233)
<https://reviews.apache.org/r/36488/#comment145527>

    Can you have multiple resource estimators running on the same node 
simultaneously? What about QoS controllers?


- Adam B


On July 14, 2015, 5:08 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36488/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 5:08 p.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added first draft of oversubscription user doc
> 
> 
> Diffs
> -----
> 
>   docs/images/oversubscription-overview.jpg PRE-CREATION 
>   docs/oversubscription.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36488/diff/
> 
> 
> Testing
> -------
> 
> Rendered at: 
> https://github.com/nqn/mesos/blob/niklas/oversubscription-user-doc/docs/oversubscription.md
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Reply via email to