----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36537/#review91895 -----------------------------------------------------------
Patch looks great! Reviews applied: [36537] All tests passed. - Mesos ReviewBot On July 16, 2015, 2:54 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36537/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 2:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy Chen. > > > Bugs: MESOS-3061 > https://issues.apache.org/jira/browse/MESOS-3061 > > > Repository: mesos > > > Description > ------- > > This would allows us to expose the docker container IP (that is queried via > docker-inspect and is part of TaskState.data) to Mesos-DNS via > Master state.json endpoint. > > Currently, Master doesn't store TaskState::data and so it's not made > available via state.json. A follow up patch would fix it. > > > Diffs > ----- > > src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 > > Diff: https://reviews.apache.org/r/36537/diff/ > > > Testing > ------- > > Tested by modifying the test_executor to send data with TASK_RUNNING status > update. The data showed up in Slave's state.json. > > > Thanks, > > Kapil Arya > >
