> On July 15, 2015, 8:46 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, lines 490-493 > > <https://reviews.apache.org/r/36494/diff/1/?file=1011986#file1011986line490> > > > > instead of calling into frameworkMessage() here can you have > > frameworkMessage() call into a new message(const Event& event) method? > > > > this is how we did it in the master and i think it will make > > deprecating old message handlers easy.
if you want to add a TODO for now and follow up soon after, that would be good too. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/#review91819 ----------------------------------------------------------- On July 15, 2015, 1:47 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36494/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:47 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2910 > https://issues.apache.org/jira/browse/MESOS-2910 > > > Repository: mesos > > > Description > ------- > > See above. > > > Diffs > ----- > > src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f > src/tests/scheduler_event_call_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36494/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
