----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36499/#review91942 -----------------------------------------------------------
Ship it! src/sched/sched.cpp (line 547) <https://reviews.apache.org/r/36499/#comment145703> TODO refactor. src/tests/scheduler_event_call_tests.cpp (lines 331 - 332) <https://reviews.apache.org/r/36499/#comment145704> why this check? src/tests/scheduler_event_call_tests.cpp (line 380) <https://reviews.apache.org/r/36499/#comment145705> No need for driver.stop() and driver.join()? Shutdown()? - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36499/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:47 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2910 > https://issues.apache.org/jira/browse/MESOS-2910 > > > Repository: mesos > > > Description > ------- > > See above. > > > Diffs > ----- > > include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a > src/common/type_utils.cpp 19f79b47539ab51a5dff97f381a44c679cf5ecaf > src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f > src/tests/scheduler_event_call_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36499/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
